Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23810 )
Change subject: IMPALA-14647: Fix truncate for replicated txn tables always delete data ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23810/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23810/1//COMMIT_MSG@14 PS1, Line 14: In HiveServer, there is a configuration, "hive.acid.truncate.usebase", I am unsure about how to configure this - does Impala use Hive configuration at other places? My concern is that an env that only uses Impala and not Hive will get a new value unintentionally (the new default for this config in Hive is true https://github.com/apache/hive/commit/0f15a02573ab59ecebf07c8bb2d8c1c3d637a7a8 ). So this is a potentially breaking change (depending on Hive config). It also doesn't ensure that Impala will work consistently with Hive as it is possible that users set this as a session configuration and not in hive-site.xml. I think that Impala should be consistent with itself and do the same thing to Hive ACID tables on truncate regardless of whether replication is enabled or not. This seems to be creating a base directory (which is also new the default in Hive). So I would change the default to not delete files, and treat the original behavior as a bug due to the inconsistency. I would also consider always calling the HMS API to ensure that things work the same way in replicated/non-replicated cases. -- To view, visit http://gerrit.cloudera.org:8080/23810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia31991baeb2ef8717c387b841b65cff562dbcae0 Gerrit-Change-Number: 23810 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 29 Dec 2025 17:16:44 +0000 Gerrit-HasComments: Yes
