Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23475 )
Change subject: IMPALA-14467: Support quoted keys with dots in get_json_object path strings ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/23475/7/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/23475/7/be/src/exprs/string-functions.cc@340 PS7, Line 340: DCHECK_LE(path_end - path, StringVal::MAX_LENGTH); > Not adding it here since 'path_str' should be valid. Instead, we need this Thank you for the suggestion. However, string-util.cc is a low-level utility library, while StringVal is a UDF framework type. Adding this DCHECK inside ParseQuotedString() would require including udf/udf.h in string-util.cc, creating an undesirable dependency on the UDF framework. If length validation is needed for UDF usage, it should be added at the caller level in the UDF layer. -- To view, visit http://gerrit.cloudera.org:8080/23475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3618d9e029501f9ac0e23190feb8263968b1b9f Gerrit-Change-Number: 23475 Gerrit-PatchSet: 7 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 05 Jan 2026 04:01:33 +0000 Gerrit-HasComments: Yes
