Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23475 )
Change subject: IMPALA-14467: Support quoted keys with dots in get_json_object path strings ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/23475/5/be/src/util/string-util-test.cc File be/src/util/string-util-test.cc: http://gerrit.cloudera.org:8080/#/c/23475/5/be/src/util/string-util-test.cc@135 PS5, Line 135: } Can we also test "\n", "\\n", "\t", "\\t" ? http://gerrit.cloudera.org:8080/#/c/23475/5/be/src/util/string-util.cc File be/src/util/string-util.cc: http://gerrit.cloudera.org:8080/#/c/23475/5/be/src/util/string-util.cc@95 PS5, Line 95: char We prefer using uint8_t over char since char type can be signed or unsigned depending on the compiler and platform. http://gerrit.cloudera.org:8080/#/c/23475/5/be/src/util/string-util.cc@107 PS5, Line 107: result->reserve(end - start); Let's add a check before this to make sure 'end - start' is a valid value, e.g. <= StringVal::MAX_LENGTH. http://gerrit.cloudera.org:8080/#/c/23475/5/be/src/util/string-util.cc@113 PS5, Line 113: result->push_back(*p); Is it true that "\t" will become "t" and "\n" will become "n"? -- To view, visit http://gerrit.cloudera.org:8080/23475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3618d9e029501f9ac0e23190feb8263968b1b9f Gerrit-Change-Number: 23475 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 10 Dec 2025 11:50:38 +0000 Gerrit-HasComments: Yes
