Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/23805 )
Change subject: IMPALA-14637: COMMIT_TXN events should trigger reload for truncate ops ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23805/5/fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java File fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java: http://gerrit.cloudera.org:8080/#/c/23805/5/fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java@26 PS5, Line 26: nit: or ABORT_TXN http://gerrit.cloudera.org:8080/#/c/23805/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23805/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2041 PS5, Line 2041: if (isTruncateOp_) { : if (Ac nit: we can combine these two if conditions into a single one and remove the else part as the logging seems unnecessary. -- To view, visit http://gerrit.cloudera.org:8080/23805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89aac12819f08dd9ed42d5d8b21a96c04b04d75c Gerrit-Change-Number: 23805 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 02 Jan 2026 19:13:34 +0000 Gerrit-HasComments: Yes
