Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23805 )
Change subject: IMPALA-14637: COMMIT_TXN events should trigger reload for truncate ops ...................................................................... Patch Set 3: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23805/3/fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java File fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java: http://gerrit.cloudera.org:8080/#/c/23805/3/fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java@44 PS3, Line 44: this.tableWriteId_ = new TableWriteId(table.getDbName(), table.getTableName(), writeId); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23805/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23805/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2045 PS3, Line 2045: long txnId = catalog_.trackTruncateOp(new TableWriteEvent(writeId, tableAfter_)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23805/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2921 PS3, Line 2921: long txnId = catalog_.trackTruncateOp(new TableWriteEvent(writeId, msTbl_, partitionAfter_)); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/23805/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@3063 PS3, Line 3063: for (org.apache.hadoop.hive.metastore.api.Partition partition : partitionsAfter_) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23805/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@3064 PS3, Line 3064: txnId = catalog_.trackTruncateOp(new TableWriteEvent(writeId, msTbl_, partition)); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89aac12819f08dd9ed42d5d8b21a96c04b04d75c Gerrit-Change-Number: 23805 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 25 Dec 2025 06:06:30 +0000 Gerrit-HasComments: Yes
