Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22462 )
Change subject: IMPALA-13687: Support shared secret key for cookies ...................................................................... Patch Set 25: (3 comments) http://gerrit.cloudera.org:8080/#/c/22462/25/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/22462/25/be/src/util/openssl-util.cc@55 PS25, Line 55: DEFINE_int32_hidden(hash_reload_grace_period_s, 300, "The time in seconds to allow " I can see admins wanting to modify this value, thus it would be better if it was not hidden. http://gerrit.cloudera.org:8080/#/c/22462/25/be/src/util/openssl-util.cc@350 PS25, Line 350: void retry_until(const std::function<bool()>& func, int sleep_ms) { This function does not appear to be used. http://gerrit.cloudera.org:8080/#/c/22462/25/docs/topics/impala_client.xml File docs/topics/impala_client.xml: http://gerrit.cloudera.org:8080/#/c/22462/25/docs/topics/impala_client.xml@342 PS25, Line 342: "Loaded authentication key from <file_path>". If the hash_reload_grace_period_s startup flag is unhidden, please document it as well. -- To view, visit http://gerrit.cloudera.org:8080/22462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e2345f771608069407e9dcf7ed4697fc0214e7 Gerrit-Change-Number: 22462 Gerrit-PatchSet: 25 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 31 Dec 2025 16:33:05 +0000 Gerrit-HasComments: Yes
