Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22462 )
Change subject: IMPALA-13687: Support shared secret key for cookies ...................................................................... Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/22462/20/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/22462/20/be/src/util/openssl-util.cc@358 PS20, Line 358: if (errno == EINTR) continue; > We should retry (maybe a hidden flag to configure the timeout that defaults Hmm, the same problem is true of earlier inotify calls. Any failure in this thread will result in an error message, but the service will continue to work. Any of these failures must be remedied by restarting the service. I think I'd rather they be errors, and if you're rotating keys then monitor for ERROR messages. Success is confirmed by seeing Loaded authentication key from ... in INFO logs. My primary reasoning about this is: if you're rotating keys, the service is already under scrutiny, and if there's an unexpected error I'd rather the admins be in control of when the service restarts rather than forcing it immediately. I've added some docs around this new functionality. -- To view, visit http://gerrit.cloudera.org:8080/22462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e2345f771608069407e9dcf7ed4697fc0214e7 Gerrit-Change-Number: 22462 Gerrit-PatchSet: 23 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 22:32:29 +0000 Gerrit-HasComments: Yes
