Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23815 )
Change subject: IMPALA-14085: [WIP] Implement GRANT/REVOKE ROLES TO/FROM a user ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23815/1/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/23815/1/common/thrift/JniCatalog.thrift@739 PS1, Line 739: 2: optional list<string> group_names > Changing field 'group_names' from required to optional in TGrantRevokeRoleP I guess it would be safer to add an additional required bool field to TGrantRevokeRoleParams, e.g., principal_type_is_group, to denote whether the grantee/revokee is a group. The current patch checks whether group_names is null when determining the type of grantee or revokee (group v.s. user). Thus, after introducing the additional bool filed, we also have to change the logic accordingly. -- To view, visit http://gerrit.cloudera.org:8080/23815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5a16aeb4bbf8637ad326a1ec3d5fce1b196d73f Gerrit-Change-Number: 23815 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 31 Dec 2025 01:48:36 +0000 Gerrit-HasComments: Yes
