Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23815 )
Change subject: IMPALA-14085: [WIP] Implement GRANT/REVOKE ROLES TO/FROM a user ...................................................................... Patch Set 1: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23815/1/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/23815/1/common/thrift/JniCatalog.thrift@739 PS1, Line 739: 2: optional list<string> group_names Changing field 'group_names' from required to optional in TGrantRevokeRoleParams might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23815/1/fe/src/main/java/org/apache/impala/analysis/GrantRevokeRoleStmt.java File fe/src/main/java/org/apache/impala/analysis/GrantRevokeRoleStmt.java: http://gerrit.cloudera.org:8080/#/c/23815/1/fe/src/main/java/org/apache/impala/analysis/GrantRevokeRoleStmt.java@71 PS1, Line 71: throw new AnalysisException("Group name and user name in GRANT/REVOKE ROLE cannot " + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23815/1/fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java File fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java: http://gerrit.cloudera.org:8080/#/c/23815/1/fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java@107 PS1, Line 107: public void revokeRoleFromGroupOrUser(User requestingUser, TGrantRevokeRoleParams params, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23815/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/23815/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@208 PS1, Line 208: public void revokeRoleFromGroupOrUser(User requestingUser, TGrantRevokeRoleParams params, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23815/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/23815/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@187 PS1, Line 187: public void revokeRoleFromGroupOrUser(User requestingUser, TGrantRevokeRoleParams params, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23815/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23815/1/tests/authorization/test_ranger.py@2301 PS1, Line 2301: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/23815/1/tests/authorization/test_ranger.py@2302 PS1, Line 2302: , flake8: E231 missing whitespace after ',' -- To view, visit http://gerrit.cloudera.org:8080/23815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5a16aeb4bbf8637ad326a1ec3d5fce1b196d73f Gerrit-Change-Number: 23815 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 31 Dec 2025 00:52:37 +0000 Gerrit-HasComments: Yes
