Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23798 )
Change subject: IMPALA-14617: Deflake TestMetadataReplicas.test_catalog_restart ...................................................................... IMPALA-14617: Deflake TestMetadataReplicas.test_catalog_restart TestMetadataReplicas.test_catalog_restart creates a db and an underlying table in Hive, then expects an INVALIDATE command can bring up the table in impalads. The test runs in the legacy catalogd mode that has the bug of IMPALA-12103. So if the INVALIDATE command runs in a state that catalgod has the db in cache but the db doesn't show up in impalad's cache yet, catalogd will just return the table and impalad will skip it due to db not exists. Then the above assertion fails. The db is added in catalogd cache by processing the CREATE_DATABASE HMS event, which is asynchronous with executing the INVALIDATE command. If the command is triggered before that, the test passes. If the command is triggered after that, the test fails. When the test was written, we don't have HMS event processing yet. It's expected that the db is also added in catalogd by the INVALIDATE command. To deflake the issue, this patch disables HMS event processing in this test, so catalogd always has a consistent cache with impalad when executing the INVALIDATE command. This patch also changes the log level of a log in ImpaladCatalog to warn if a table is not added due to its db is missing. Tests: - Ran the test locally 10 times. Change-Id: I2d17404cc8093eacf9b51df3d22caf5cbb6a61a9 Reviewed-on: http://gerrit.cloudera.org:8080/23798 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M tests/custom_cluster/test_metadata_replicas.py 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2d17404cc8093eacf9b51df3d22caf5cbb6a61a9 Gerrit-Change-Number: 23798 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
