Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23798 )
Change subject: IMPALA-14617: Deflake TestMetadataReplicas.test_catalog_restart ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/23798/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23798/1//COMMIT_MSG@22 PS1, Line 22: When the test was written, we don't have HMS event processing yet. It's : expected that the db is also added in catalogd by the INVALIDATE : command. To deflake the issue, this patch disables HMS event processing : in this test, so catalogd always has a consistent cache with impalad : when executing the INVALIDATE command. This make sense to me. http://gerrit.cloudera.org:8080/#/c/23798/1/tests/custom_cluster/test_metadata_replicas.py File tests/custom_cluster/test_metadata_replicas.py: http://gerrit.cloudera.org:8080/#/c/23798/1/tests/custom_cluster/test_metadata_replicas.py@32 PS1, Line 32: """ Validates metadata content across catalogd and impalad coordinators. : This test is only valid in legacy catalog mode. """ nit: Please add small comments on why event processing SHOULD NOT be enable here. This will help future maintainer to pay attention to it. -- To view, visit http://gerrit.cloudera.org:8080/23798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d17404cc8093eacf9b51df3d22caf5cbb6a61a9 Gerrit-Change-Number: 23798 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 17:14:46 +0000 Gerrit-HasComments: Yes
