Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23777 )
Change subject: IMPALA-14370: OpenTelemetry Query Tracing Skips Queries with Leading Comments ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23777/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23777/2//COMMIT_MSG@16 PS2, Line 16: Replaces the parser with a more robust parser that properly handles Is syntax parsing so expensive we need to reimplement it for this case? I've also forgotten why we skip tracing some queries. -- To view, visit http://gerrit.cloudera.org:8080/23777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1425b32006f81586bf75c2e4045d23bab91e1611 Gerrit-Change-Number: 23777 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 23:10:06 +0000 Gerrit-HasComments: Yes
