Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23777
Change subject: IMPALA-14370: OpenTelemetry Query Tracing Skips Queries with Leading Comments ...................................................................... IMPALA-14370: OpenTelemetry Query Tracing Skips Queries with Leading Comments Since OpenTelemetry traces must be opened before query planning starts, a rudimentry text parser was implemented to determine, based on the first query keyword, if the query should be traced. This parser could be fooled by a multiline comment such as: /*/ comment */ select * from db.tbl This type of leading comment would cause query tracing to be skipped. Replaces the parser with a more robust parser that properly handles the previously noted issue. Testing accomplished by adding test cases and moving the one test case noted as needing to be moved when this Jira is fixed. Removed the custom cluster test that asserts certain queries are not traced since this test duplicates the otel-test ctest. Generated-by: Github Copilot (Claude Sonnet 4.5) Change-Id: I1425b32006f81586bf75c2e4045d23bab91e1611 --- M be/src/observe/otel-test.cc M be/src/observe/otel.cc M tests/custom_cluster/test_otel_trace.py 3 files changed, 60 insertions(+), 122 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/23777/2 -- To view, visit http://gerrit.cloudera.org:8080/23777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1425b32006f81586bf75c2e4045d23bab91e1611 Gerrit-Change-Number: 23777 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]>
