Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23652 )
Change subject: IMPALA-13844: Add /stacks web page to dump native thread stacks ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/23652/3/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/23652/3/be/src/common/init.cc@594 PS3, Line 594: // We use SIGRTMIN+10 instead of SIGUSR1/SIGUSR2 because: > Why do we need this? Is it an additional feature that using signals to trig The signal handler is not meant to be manually triggered. It's designed to only be called internally by StackTraceSnapshot::SnapshotAllStacks() through the web endpoint. The crash happens because: The handler expects a data pointer passed via sigqueue() When you use kill -44, no data is attached, causing sig_data to be NULL and the DCHECK to fail http://gerrit.cloudera.org:8080/#/c/23652/3/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/23652/3/be/src/util/default-path-handlers.cc@218 PS3, Line 218: eSnapshot::Threa > Some thread names are different with what we show in the "/thread-group?all We are now using Impala's thread manager for consistent naming ``` 2 threads with same stack: TID 262354 (periodic-system-counter-updater): TID 262353 (periodic-counter-updater): @ 0x7fb8312e7520 (unknown) @ 0x7fb83138a7f8 clock_nanosleep @ 0x7fb83138f677 __nanosleep @ 0x1c94174 impala::SleepForMs() @ 0x1c2908f impala::PeriodicCounterUpdater::UpdateLoop() @ 0x1c2b6b6 boost::detail::function::void_function_obj_invoker0<>::invoke() @ 0x1c91024 impala::Thread::SuperviseThread() @ 0x1c91b29 boost::detail::thread_data<>::run() @ 0x27d8a67 thread_proxy @ 0x7fb831339ac3 (unknown) @ 0x7fb8313cb850 (unknown) TID 262351 (log-maintenance-thread): @ 0x7fb8312e7520 (unknown) @ 0x7fb83138a7f8 clock_nanosleep @ 0x7fb83138f677 __nanosleep @ 0x7fb83138f5ae sleep @ 0x1259c31 LogMaintenanceThread() @ 0x1261f3d boost::detail::function::void_function_invoker0<>::invoke() @ 0x1c91024 impala::Thread::SuperviseThread() @ 0x1c91b29 boost::detail::thread_data<>::run() @ 0x27d8a67 thread_proxy @ 0x7fb831339ac3 (unknown) @ 0x7fb8313cb850 (unknown) TID 264531 (log-flush-thread): @ 0x7fb8312e7520 (unknown) @ 0x7fb83138a7f8 clock_nanosleep @ 0x7fb83138f677 __nanosleep @ 0x7fb83138f5ae sleep @ 0x192a290 impala::ImpalaServer::LogFileFlushThread() @ 0x1964f7b boost::detail::function::void_function_obj_invoker0<>::invoke() @ 0x1c91024 impala::Thread::SuperviseThread() @ 0x1c91b29 boost::detail::thread_data<>::run() @ 0x27d8a67 thread_proxy @ 0x7fb831339ac3 (unknown) @ 0x7fb8313cb850 (unknown) ``` http://gerrit.cloudera.org:8080/#/c/23652/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/23652/2/tests/webserver/test_web_pages.py@230 PS2, Line 230: input_url = self.STACKS_URL.format(port) > I don't think these format checks would be expensive to do on every daemon. Done http://gerrit.cloudera.org:8080/#/c/23652/3/www/threadz.tmpl File www/threadz.tmpl: http://gerrit.cloudera.org:8080/#/c/23652/3/www/threadz.tmpl@29 PS3, Line 29: <a href="{{ __common__.host-url }}/thread-group?all"><h5>All threads</h5></a> > Let's add another link here for "Stacks" using the new endpoint. Done -- To view, visit http://gerrit.cloudera.org:8080/23652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9171c89d1d36726d98a4a61ca040d69254f50e92 Gerrit-Change-Number: 23652 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 10 Dec 2025 18:39:23 +0000 Gerrit-HasComments: Yes
