Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23652 )
Change subject: IMPALA-13844: Add /stacks web page to dump native thread stacks ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23652/3/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/23652/3/be/src/common/init.cc@594 PS3, Line 594: kudu::Status stack_trace_status = kudu::SetStackTraceSignal(stack_trace_signal); Why do we need this? Is it an additional feature that using signals to trigger dumping stacktrace? If so, where can we get the output? I tried "kill -44" on one impalad but it crashes: F20251117 17:52:46.978693 344156 debug-util.cc:266] Check failed: sig_data *** Check failure stack trace: *** @ 0x3c0fb6d google::LogMessage::Fail() @ 0x3c13105 google::LogMessage::SendToLog() @ 0x3c0f57b google::LogMessage::Flush() @ 0x3c10b39 google::LogMessageFatal::~LogMessageFatal() @ 0x13cdd14 kudu::(anonymous namespace)::HandleStackTraceSignal() @ 0x7b4c08242520 (unknown) @ 0x7b4c08291115 (unknown) @ 0x7b4c08293a41 pthread_cond_wait @ 0x1571c7d boost::condition_variable::wait() @ 0x26bf884 boost::thread::join_noexcept() @ 0x14a8e1a impala::ImpalaServicePool::Join() @ 0x1496b9f impala::RpcMgr::Join() @ 0x1821851 impala::ImpalaServer::Join() @ 0x181a2f4 ImpaladMain() @ 0xff4acc main @ 0x7b4c08229d90 (unknown) @ 0x7b4c08229e40 __libc_start_main @ 0xff4925 _start @ (nil) (unknown) http://gerrit.cloudera.org:8080/#/c/23652/3/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/23652/3/be/src/util/default-path-handlers.cc@218 PS3, Line 218: info.thread_name Some thread names are different with what we show in the "/thread-group?all" page. E.g. "log-maintenance-thread" shown as "impalad". Can we fix them? http://gerrit.cloudera.org:8080/#/c/23652/3/www/threadz.tmpl File www/threadz.tmpl: http://gerrit.cloudera.org:8080/#/c/23652/3/www/threadz.tmpl@29 PS3, Line 29: <a href="{{ __common__.host-url }}/thread-group?all"><h5>All threads</h5></a> Let's add another link here for "Stacks" using the new endpoint. -- To view, visit http://gerrit.cloudera.org:8080/23652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9171c89d1d36726d98a4a61ca040d69254f50e92 Gerrit-Change-Number: 23652 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 17 Nov 2025 09:57:20 +0000 Gerrit-HasComments: Yes
