Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22462 )
Change subject: IMPALA-13687: Support shared secret key for cookies ...................................................................... Patch Set 17: Code-Review+1 (1 comment) Thanks for adding these tests. An Init() function might clean up the death test, but I can also live with the current EXPECT_DEATH code. http://gerrit.cloudera.org:8080/#/c/22462/16/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/22462/16/be/src/util/openssl-util-test.cc@550 PS16, Line 550: AuthenticationHashFromFile auth_hash(missing_key_path); > These don't capture any output, possibly because they're redirected to a lo These tests are great. I'm not sure what is going on with the output. In theory, it should be possible to match the LOG(FATAL) output. One way around this is to add an Init() function that returns Status and require it to be called after construction. The place that initializes the AuthenticationHash already returns status, so it could work. -- To view, visit http://gerrit.cloudera.org:8080/22462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e2345f771608069407e9dcf7ed4697fc0214e7 Gerrit-Change-Number: 22462 Gerrit-PatchSet: 17 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 02 Dec 2025 18:16:12 +0000 Gerrit-HasComments: Yes
