Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22462 )
Change subject: IMPALA-13687: Support shared secret key for cookies ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/22462/16/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/22462/16/be/src/util/openssl-util-test.cc@550 PS16, Line 550: }, ""); These don't capture any output, possibly because they're redirected to a log file. I manually reviewed the log file contents, but open to other suggestions. http://gerrit.cloudera.org:8080/#/c/22462/14/be/src/util/openssl-util.h File be/src/util/openssl-util.h: http://gerrit.cloudera.org:8080/#/c/22462/14/be/src/util/openssl-util.h@164 PS14, Line 164: /// Destructor to shut down the reload thread and signal it to stop. : ~AuthenticationHashFromFile() override { : // Signal the reload thread to stop. : if (stop_pipe_write_fd_ >= 0) { : write(stop_pipe_write_fd_, "x", 1); // Write a byte to signal shutdown. : close(stop_pipe_write_fd_); : } : if (reload_thread_.joinable()) { : reload_thread_.join(); : } : } > Several of the frontend custom-cluster tests exercise some part of this, su Added some unit tests for AuthenticationHashFromFile that should verify that the destructor exits cleanly. http://gerrit.cloudera.org:8080/#/c/22462/14/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/22462/14/be/src/util/openssl-util.cc@358 PS14, Line 358: if (Status stat = LoadKey(); !stat.ok()) { : LOG(ERROR) << "Failed to reload authentication key: " << stat; > Yeah, those make sense. Added death tests for non-existent and too short file, and a unit test that verifies the key doesn't change if we write a bad file. -- To view, visit http://gerrit.cloudera.org:8080/22462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e2345f771608069407e9dcf7ed4697fc0214e7 Gerrit-Change-Number: 22462 Gerrit-PatchSet: 16 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 27 Nov 2025 00:10:29 +0000 Gerrit-HasComments: Yes
