Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages ...................................................................... Patch Set 6: > Patch Set 5: > > I think we should probably have some sort of README in the java/ directory. Some docs would be good. It took me awhile to understand why this approach was taken. My understanding is this approach utilizes Maven's dependency resolution process to ensure duplicate dependencies are not added to the classpath. That prompts something else -- if adding a readme, please also add a comment in java/impala-package/pom.xml that the impala-frontend dependency should be listed first to help conflicting dependency versions to favor the dependency version required by impala-frontend. Once we get off Java 8, we should look into java modules, but that's for another day. -- To view, visit http://gerrit.cloudera.org:8080/23497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793 Gerrit-Change-Number: 23497 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 20 Nov 2025 23:54:17 +0000 Gerrit-HasComments: No
