Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh File bin/set-classpath.sh: http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@41 PS4, Line 41: $PACKAGE_CP_FILE > Nit: Need to double quote: "$PACKAGE_CP_FILE" Done http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@46 PS4, Line 46: $PACKAGE_CP_FILE > Nit: Need to double quote: "$PACKAGE_CP_FILE" Done http://gerrit.cloudera.org:8080/#/c/23497/4/bin/set-classpath.sh@50 PS4, Line 50: $FE_TEST_CP_FILE > Nit: Need to double quote: "$FE_TEST_CP_FILE" Done http://gerrit.cloudera.org:8080/#/c/23497/4/tests/custom_cluster/test_query_event_hooks.py File tests/custom_cluster/test_query_event_hooks.py: http://gerrit.cloudera.org:8080/#/c/23497/4/tests/custom_cluster/test_query_event_hooks.py@80 PS4, Line 80: "target", "impala-frontend-{0}-tests.jar".format(os.getenv("IMPALA_VERSION"))) > Nit: Could move this into a separate function and eliminate the duplicate Done -- To view, visit http://gerrit.cloudera.org:8080/23497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793 Gerrit-Change-Number: 23497 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 19 Nov 2025 21:43:49 +0000 Gerrit-HasComments: Yes
