Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: WIP IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 1: (9 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/common.h File be/src/exprs/geo/common.h: http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/common.h@38 PS1, Line 38: // see https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df669cbfaaf1edbfac0461acd1af45e12b81/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L21 line too long (168 > 90) http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/common.h@41 PS1, Line 41: ST_POINT = 1, tab used for whitespace http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/common.h@42 PS1, Line 42: ST_LINESTRING = 2, tab used for whitespace http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/common.h@43 PS1, Line 43: ST_POLYGON = 3, tab used for whitespace http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/common.h@44 PS1, Line 44: ST_MULTIPOINT = 4, tab used for whitespace http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/common.h@45 PS1, Line 45: ST_MULTILINESTRING = 5, tab used for whitespace http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/common.h@46 PS1, Line 46: ST_MULTIPOLYGON = 6 tab used for whitespace http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/shape-format.h File be/src/exprs/geo/shape-format.h: http://gerrit.cloudera.org:8080/#/c/23700/1/be/src/exprs/geo/shape-format.h@45 PS1, Line 45: // See https://github.com/Esri/geometry-api-java/blob/d9ed3598b72029c9ebde024e0e616933cff81db2/src/main/java/com/esri/core/geometry/ShapeType.java#L27 line too long (150 > 90) http://gerrit.cloudera.org:8080/#/c/23700/1/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/23700/1/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@62 PS1, Line 62: private final static Logger LOG = LoggerFactory.getLogger(HiveEsriGeospatialBuiltins.class); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 20 Nov 2025 20:15:03 +0000 Gerrit-HasComments: Yes
