Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23700
Change subject: WIP IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... WIP IMPALA-14573: port critical geospatial functions to c++ (part 1) This commit contains the simpler parts from https://gerrit.cloudera.org/#/c/20602 Differences from the PR above: Only a subset of functions are added. The criteria is: 1. the native function must be fully compatible with the Java version* 2. must not rely on (de)serializing the full geometry 3. all overloads of the function must be tested 1 implies 2 because (de)serialization is not implemented yet in the original patch for >2d geometries, which would break compatibility for the Java version for ZYZ/XYM/XYZM geometries. *: The only difference I know about is NULL handling - the Java functions return error instead of NULL when getting a NULL parameter. NULL handling has no tests yet. Because the native functions are safe replacements for the Java ones, they are always used when geospatial_library=HIVE_ESRI. Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c TODO: actually explain the patch --- M be/CMakeLists.txt M be/src/codegen/CMakeLists.txt M be/src/codegen/impala-ir.cc M be/src/exprs/CMakeLists.txt A be/src/exprs/geo/CMakeLists.txt A be/src/exprs/geo/common.h A be/src/exprs/geo/geospatial-functions-ir.cc A be/src/exprs/geo/geospatial-functions.h A be/src/exprs/geo/shape-format.h M be/src/exprs/scalar-expr-evaluator.cc M fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java A testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-extra.test M testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test M tests/custom_cluster/test_geospatial_library.py M tests/query_test/test_geospatial_functions.py 15 files changed, 967 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/23700/1 -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]>
