Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23566 )
Change subject: IMPALA-14065: Support WHERE clause in SHOW PARTITIONS statement ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@581 PS1, Line 581: > Maybe you can change it to something like this: I refactored the code into 3 helper methods: 1. buildTableStatsSchema(TResultSet result) 2. buildPartitionStatsRow(FeFsPartition p, boolean statsExtrap, TResultSet result) 3. buildTotalStatsRow(...) This reduces redundancy and keeps things clean http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@581 PS1, Line 581: > Please try reduce duplicate codes here by extracting common codes against g Checked all implementations of getTableStats(): 1. FeIcebergTable: Delegates to underlying FeFsTable, so it automatically inherits the new getTableStatsForPartitions() method 2. FePaimonTable: Has its own getTableStats(TShowStatsOp op) implementation and doesn't support partition filtering (supportPartitionFilter() returns false) 3. Other table types (DataSource, HBase, System): Don't extend FeFsTable and don't support SHOW PARTITIONS WHERE No additional implementations of getTableStatsForPartitions() are needed -- To view, visit http://gerrit.cloudera.org:8080/23566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2a14aabcea3fb17083d4ad6f87b7861113f89e Gerrit-Change-Number: 23566 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 18:38:50 +0000 Gerrit-HasComments: Yes
