Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23566 )
Change subject: IMPALA-14065: Support WHERE clause in SHOW PARTITIONS statement ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@581 PS1, Line 581: default TResultSet getTableStatsForPartitions(Collection<Long> partitionIds) { > Please try reduce duplicate codes here by extracting common codes against g Maybe you can change it to something like this: default TResultSet getTableStats() { return getTableStatsForPartitions(Optional.empty()); } default TResultSet getTableStatsForPartitions(Optional<Collection<Long>> partitionIds) { ... List<FeFsPartition> orderedPartitions = new ArrayList<>( partitionIds.isPresent() ? loadPartitions(partitionIds.get()) : loadAllPartitions()); ... } -- To view, visit http://gerrit.cloudera.org:8080/23566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2a14aabcea3fb17083d4ad6f87b7861113f89e Gerrit-Change-Number: 23566 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 18:04:11 +0000 Gerrit-HasComments: Yes
