Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/23436 )
Change subject: IMPALA-14447: Parallelize table loading in getMissingTables() ...................................................................... Patch Set 16: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23436/16/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/23436/16/be/src/util/backend-gflag-util.cc@369 PS16, Line 369: Nit: Could consider a validator or bounding settings but we don't seem to do that for many parameters. http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@403 PS11, Line 403: // Otherwise, wrap as InternalException and rethrow. > It is there is patch set 14. Done http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java File fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java: http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@202 PS11, Line 202: try { > LocalDb.getTableIfCached() and LocalDb.getTable() calls tables_.put(). So c Done -- To view, visit http://gerrit.cloudera.org:8080/23436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97a5165844ae846b28338d62e93a20121488d79f Gerrit-Change-Number: 23436 Gerrit-PatchSet: 16 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 08 Oct 2025 01:44:02 +0000 Gerrit-HasComments: Yes
