Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23436 )
Change subject: IMPALA-14447: Parallelize table loading in getMissingTables() ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@403 PS11, Line 403: InconsistentMetadataFetchException.class, LocalCatalogException.class); > I don't see the 2nd suggestion implemented. It is there is patch set 14. List<Pair<TableName, FeTable>> tables = (maxThreads <= 1) ? serialTableLoad(catalog, tbls) : parallelTableLoad(catalog, tbls); http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java File fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java: http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@118 PS11, Line 118: List<String> names; > ConcurrentHashMap is only needed when there are concurrent modifications. Changed this to ImmutableMap. http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java File fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java: http://gerrit.cloudera.org:8080/#/c/23436/11/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@202 PS11, Line 202: try { > ConcurrentHashMap is only needed when there are concurrent modifications. LocalDb.getTableIfCached() and LocalDb.getTable() calls tables_.put(). So concurrent modification is possible here. -- To view, visit http://gerrit.cloudera.org:8080/23436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97a5165844ae846b28338d62e93a20121488d79f Gerrit-Change-Number: 23436 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 07 Oct 2025 20:52:34 +0000 Gerrit-HasComments: Yes
