Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23315 )
Change subject: IMPALA-14102: [part 3] Calcite Planner: Customize LoptOptimizeJoinRule ...................................................................... Patch Set 11: Code-Review+1 (1 comment) I think this is OK as we iterate more in next patches. FYI, I did this just to compare the resource estimation, which is a proxy on how different the plan tree is compared to classic planner. diff ./testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds_cpu_cost/ ./testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/ | grep -e \.test -e 'Per-Host Resource' We should revisit one where Calcite planner produce distributed/parallel plan with much bigger memory estimate, like in tpcds-q23a.test. http://gerrit.cloudera.org:8080/#/c/23315/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23315/9//COMMIT_MSG@15 PS9, Line 15: The use of runtime filters within Impala throw a wrench into the join optimization : ordering. > This is definitely true. The rules in Impala are simple. Ack. The wording in commit message sounds aligned with what I understood from the classic Impala planner. -- To view, visit http://gerrit.cloudera.org:8080/23315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95bba7bafcc7dd86f17921c11740ac349daac6c7 Gerrit-Change-Number: 23315 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (846) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 24 Sep 2025 21:55:19 +0000 Gerrit-HasComments: Yes
