Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23315 )
Change subject: IMPALA-14102: [part 3] Calcite Planner: Customize LoptOptimizeJoinRule ...................................................................... Patch Set 9: (4 comments) I also only have nits. http://gerrit.cloudera.org:8080/#/c/23315/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23315/9//COMMIT_MSG@15 PS9, Line 15: The use of runtime filters within Impala throw a wrench into the join optimization : ordering. AFAIK, classic impala planner does not consider runtime filter at all during single-node planning. So I suspect there are simpler rule that govern this. ie., scan with largest cardinality will be put on the leftmost tree it will materialize fewer row batches at a time (stream to upper pipeline, avoid broadcast/shuffle from right hand side, etc). Note also that runtime filter can be disabled in Impala, but that will not impact how the plan tree looks like. http://gerrit.cloudera.org:8080/#/c/23315/9//COMMIT_MSG@23 PS9, Line 23: "leftest most" nit: "leftmost" http://gerrit.cloudera.org:8080/#/c/23315/9//COMMIT_MSG@36 PS9, Line 36: "leftest" most nit: "leftmost" http://gerrit.cloudera.org:8080/#/c/23315/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23315/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2113 PS8, Line 2113: ntime filter compa getLeftmostRowWidth sounds better. -- To view, visit http://gerrit.cloudera.org:8080/23315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95bba7bafcc7dd86f17921c11740ac349daac6c7 Gerrit-Change-Number: 23315 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (846) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 19 Sep 2025 18:36:24 +0000 Gerrit-HasComments: Yes
