Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23154 )
Change subject: IMPALA-9846: Enable Aggregated Runtime Profile by Default ...................................................................... Patch Set 17: (47 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23154/17/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/23154/17/be/src/util/runtime-profile.cc@2320 PS17, Line 2320: (*s) << prefix << " - " << name << ": total=" << PrettyPrinter::Print(BitcastToInt64(stats.total), unit_, true); line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@189 PS17, Line 189: def try_compile_row_regex(row_string): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@580 PS17, Line 580: AGGREGATION_PREFIX_PATTERN = r'aggregation\(' flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@582 PS17, Line 582: w flake8: E501 line too long (131 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@624 PS17, Line 624: class CounterType(Enum): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@625 PS17, Line 625: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@631 PS17, Line 631: def try_compile_profile_search_object(row_string, agg_profile=True): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@633 PS17, Line 633: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@634 PS17, Line 634: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@635 PS17, Line 635: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@636 PS17, Line 636: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@637 PS17, Line 637: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@638 PS17, Line 638: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@639 PS17, Line 639: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@640 PS17, Line 640: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@641 PS17, Line 641: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@642 PS17, Line 642: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@664 PS17, Line 664: ( flake8: E275 missing whitespace after keyword http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@676 PS17, Line 676: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@687 PS17, Line 687: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@736 PS17, Line 736: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@738 PS17, Line 738: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/23154/17/tests/common/test_result_verifier.py@845 PS17, Line 845: n flake8: E713 test for membership should be 'not in' http://gerrit.cloudera.org:8080/#/c/23154/17/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/custom_cluster/test_admission_controller.py@704 PS17, Line 704: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/custom_cluster/test_runtime_profile.py File tests/custom_cluster/test_runtime_profile.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/custom_cluster/test_runtime_profile.py@36 PS17, Line 36: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/23154/17/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/custom_cluster/test_tuple_cache.py@88 PS17, Line 88: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_observability.py@82 PS17, Line 82: G flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_observability.py@91 PS17, Line 91: I flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_parquet_bloom_filter.py File tests/query_test/test_parquet_bloom_filter.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_parquet_bloom_filter.py@141 PS17, Line 141: 1 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_parquet_bloom_filter.py@143 PS17, Line 143: 1 flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_parquet_bloom_filter.py@144 PS17, Line 144: ] flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_parquet_bloom_filter.py@180 PS17, Line 180: 1 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_parquet_bloom_filter.py@182 PS17, Line 182: 0 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_runtime_filters.py@160 PS17, Line 160: n flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_runtime_filters.py@161 PS17, Line 161: o flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_scanners.py@413 PS17, Line 413: i flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_scanners.py@431 PS17, Line 431: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_scanners.py@433 PS17, Line 433: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_scanners.py@1443 PS17, Line 1443: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_scanners.py@1444 PS17, Line 1444: r flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_scanners.py@1448 PS17, Line 1448: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_scanners.py@1451 PS17, Line 1451: r flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_sort.py@124 PS17, Line 124: l flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/query_test/test_sort.py@402 PS17, Line 402: r flake8: E501 line too long (115 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/17/tests/unittests/test_result_verifier.py File tests/unittests/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/unittests/test_result_verifier.py@54 PS17, Line 54: flake8: W292 no newline at end of file http://gerrit.cloudera.org:8080/#/c/23154/17/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/23154/17/tests/util/workload_management.py@526 PS17, Line 526: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23154/17/tests/util/workload_management.py@526 PS17, Line 526: l flake8: E501 line too long (117 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/23154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41d6322361fba82c946efd614cc7d28cb1c36e8 Gerrit-Change-Number: 23154 Gerrit-PatchSet: 17 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Sat, 18 Oct 2025 18:40:27 +0000 Gerrit-HasComments: Yes
