Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23154 )
Change subject: IMPALA-9846: Enable Aggregated Runtime Profile by Default ...................................................................... Patch Set 12: (40 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23154/12/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/23154/12/be/src/util/runtime-profile.cc@2320 PS12, Line 2320: (*s) << prefix << " - " << name << ": total=" << PrettyPrinter::Print(stats.total, unit_, true); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/23154/12/be/src/util/runtime-profile.cc@2397 PS12, Line 2397: counter_json.AddMember("total", static_cast<double>(stats.total), document.GetAllocator()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@189 PS12, Line 189: def try_compile_row_regex(row_string): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@580 PS12, Line 580: AGGREGATION_PREFIX_PATTERN = r'aggregation\(' flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@582 PS12, Line 582: w flake8: E501 line too long (131 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@624 PS12, Line 624: class CounterType(Enum): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@625 PS12, Line 625: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@631 PS12, Line 631: def try_compile_profile_search_object(row_string, agg_profile=True): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@633 PS12, Line 633: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@634 PS12, Line 634: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@635 PS12, Line 635: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@636 PS12, Line 636: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@637 PS12, Line 637: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@638 PS12, Line 638: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@639 PS12, Line 639: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@640 PS12, Line 640: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@641 PS12, Line 641: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@642 PS12, Line 642: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@664 PS12, Line 664: ( flake8: E275 missing whitespace after keyword http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@676 PS12, Line 676: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@687 PS12, Line 687: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@735 PS12, Line 735: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@737 PS12, Line 737: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/23154/12/tests/common/test_result_verifier.py@844 PS12, Line 844: n flake8: E713 test for membership should be 'not in' http://gerrit.cloudera.org:8080/#/c/23154/12/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/custom_cluster/test_admission_controller.py@704 PS12, Line 704: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/custom_cluster/test_runtime_profile.py File tests/custom_cluster/test_runtime_profile.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/custom_cluster/test_runtime_profile.py@36 PS12, Line 36: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/23154/12/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/custom_cluster/test_tuple_cache.py@90 PS12, Line 90: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_observability.py@82 PS12, Line 82: G flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_observability.py@91 PS12, Line 91: I flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_parquet_bloom_filter.py File tests/query_test/test_parquet_bloom_filter.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_parquet_bloom_filter.py@141 PS12, Line 141: 1 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_parquet_bloom_filter.py@143 PS12, Line 143: 1 flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_parquet_bloom_filter.py@144 PS12, Line 144: ] flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_parquet_bloom_filter.py@180 PS12, Line 180: 1 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_parquet_bloom_filter.py@182 PS12, Line 182: 0 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_runtime_filters.py@160 PS12, Line 160: n flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_runtime_filters.py@161 PS12, Line 161: o flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_scanners.py@413 PS12, Line 413: i flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_scanners.py@431 PS12, Line 431: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23154/12/tests/query_test/test_scanners.py@433 PS12, Line 433: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/23154/12/tests/unittests/test_result_verifier.py File tests/unittests/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/23154/12/tests/unittests/test_result_verifier.py@54 PS12, Line 54: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/23154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41d6322361fba82c946efd614cc7d28cb1c36e8 Gerrit-Change-Number: 23154 Gerrit-PatchSet: 12 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 06 Oct 2025 19:21:36 +0000 Gerrit-HasComments: Yes
