Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23519 )
Change subject: IMPALA-14452: Fix impala-shell SSL with Python 3.12 ...................................................................... Patch Set 12: > Patch Set 11: > > I see that some of my ipv6 tests failed: > https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/6945/testReport/custom_cluster.test_ipv6/TestIPv6OnlySsl/test_ipv6_only_ssl__table_format__text_none_____protocol__hs2_____impala_shell__dev3_____exec_option____abort_on_error___1___batch_size___0___disable_codegen___False___disable_codegen_rows_threshold___0___exec_single_node_rows_threshold___0___num_nodes___0___test_replan___1___/ > > The issue is that a different error message is expected. > This is what Impala gets: > [Exception] Error connecting TTransportException Could not connect to any of > [('::1', 21050, 0, 0)] > > the test expects one of these in the exception: > "doesn't match", "certificate verify failed" > > The expectation is that shell will complain about hostname matching, as the > certificate is for *.impala.test, so it should reject an ip address. I'm uncertain why the message changed in Python 3.8. I'll investigate. -- To view, visit http://gerrit.cloudera.org:8080/23519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046a9010ac4cb1f7d705935054b306cddaf8bdc7 Gerrit-Change-Number: 23519 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 17 Oct 2025 20:28:51 +0000 Gerrit-HasComments: No
