Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23519 )
Change subject: IMPALA-14452: Fix impala-shell SSL with Python 3.12 ...................................................................... Patch Set 9: Code-Review+1 (2 comments) This is looking good to me http://gerrit.cloudera.org:8080/#/c/23519/9/shell/impala_shell/TSSLSocketWithFixes.py File shell/impala_shell/TSSLSocketWithFixes.py: http://gerrit.cloudera.org:8080/#/c/23519/9/shell/impala_shell/TSSLSocketWithFixes.py@1 PS9, Line 1: #!/usr/bin/env python : # FYI: I had a separate change to remove this from TSSLSocketWithWildcardSAN.py and unset the executable bit for the file. We can keep it separate or include it here. I don't have a preference. http://gerrit.cloudera.org:8080/#/c/23519/9/shell/impala_shell/impala_client.py File shell/impala_shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/23519/9/shell/impala_shell/impala_client.py@496 PS9, Line 496: if self.use_ssl: : # TSSLSocket needs the ssl module, which may not be standard on all Operating : # Systems. Only attempt to import TSSLSocket if the user wants an SSL connection. : from impala_shell.TSSLSocketWithFixes import TSSLSocketWithFixes Nit: Not your change, but this is probably obsolete and could move to the top of the file with the rest of the imports. We import ssl at the top of this file. We can do that in a separate change if we want. -- To view, visit http://gerrit.cloudera.org:8080/23519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046a9010ac4cb1f7d705935054b306cddaf8bdc7 Gerrit-Change-Number: 23519 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 19:37:20 +0000 Gerrit-HasComments: Yes
