Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23434 )
Change subject: IMPALA-14450: Simplify Java version selection ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23434/5/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/23434/5/bin/run-all-tests.sh@39 PS5, Line 39: if [ ! -z "${TEST_JAVA_HOME_OVERRIDE:-}" ]; then > I'd be tempted to remove this. Not sure it's ever been used. Agree to drop TEST_JAVA_HOME_OVERRIDE. So far, I only ever use IMPALA_JDK_VERSION and TEST_JDK_VERSION to control variations. -- To view, visit http://gerrit.cloudera.org:8080/23434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68435ca69522f8310221a0f3050f13d86568b9da Gerrit-Change-Number: 23434 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 00:27:25 +0000 Gerrit-HasComments: Yes
