Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23434 )
Change subject: IMPALA-14450: Simplify Java version selection ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23434/5/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/23434/5/bin/run-all-tests.sh@36 PS5, Line 36: # Preserve build-time JAVA_HOME to restore to its original value in I need to retest this. An addendum to IMPALA-14187 mentioned it was a problem with IMPALA_JDK_VERSION=8 and TEST_JDK_VERSION=17. I think specifically this was about ensuring all test code was compiled targeting Java 8, so maybe just restoring IMPALA_JAVA_TARGET is still the right thing to do. -- To view, visit http://gerrit.cloudera.org:8080/23434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68435ca69522f8310221a0f3050f13d86568b9da Gerrit-Change-Number: 23434 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 17 Sep 2025 23:22:22 +0000 Gerrit-HasComments: Yes
