Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23363 )
Change subject: IMPALA-14349: Encode FileDescriptors in time in loading Iceberg Tables ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23363/6/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23363/6/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@307 PS6, Line 307: protected FileDescriptor createFd(FileSystem fs, FileStatus fileStatus, : String relPath, Reference<Long> numUnknownDiskIds, String absPath) : throws IOException { : BlockLocation[] locations; : if (fileStatus instanceof LocatedFileStatus) { : locations = ((LocatedFileStatus) fileStatus).getBlockLocations(); : } else if (FileSystemUtil.supportsStorageIds(fs)) { : locations = fs.getFileBlockLocations(fileStatus, 0, fileStatus.getLen()); : } else { : return FileDescriptor.createWithNoBlocks(fileStatus, relPath, absPath); : } : return FileDescriptor.create(fileStatus, relPath, locations, hostIndex_, : fileStatus.isEncrypted(), fileStatus.isErasureCoded(), numUnknownDiskIds, : absPath); : } > I think this broke S3 data loading from HDFS snapshot. Saw this in downstre Filed https://issues.apache.org/jira/browse/IMPALA-14437 -- To view, visit http://gerrit.cloudera.org:8080/23363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c2a7119d76db7ce7c43caec2ccb122a014851b Gerrit-Change-Number: 23363 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 14 Sep 2025 15:10:14 +0000 Gerrit-HasComments: Yes
