Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23363 )
Change subject: IMPALA-14349: Encode FileDescriptors in time in loading Iceberg Tables ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23363/6/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23363/6/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@307 PS6, Line 307: protected FileDescriptor createFd(FileSystem fs, FileStatus fileStatus, : String relPath, Reference<Long> numUnknownDiskIds, String absPath) : throws IOException { : BlockLocation[] locations; : if (fileStatus instanceof LocatedFileStatus) { : locations = ((LocatedFileStatus) fileStatus).getBlockLocations(); : } else if (FileSystemUtil.supportsStorageIds(fs)) { : locations = fs.getFileBlockLocations(fileStatus, 0, fileStatus.getLen()); : } else { : return FileDescriptor.createWithNoBlocks(fileStatus, relPath, absPath); : } : return FileDescriptor.create(fileStatus, relPath, locations, hostIndex_, : fileStatus.isEncrypted(), fileStatus.isErasureCoded(), numUnknownDiskIds, : absPath); : } I think this broke S3 data loading from HDFS snapshot. Saw this in downstream build. I20250910 07:36:52.709887 63842 Frontend.java:2431] 8a47939d765631e1:4821604e00000000] Analyzing query: INSERT into TABLE functional_kudu.alltypes SELECT id, bool_col, tinyint_col, smallint_col, int_col, bigint_col, float_col, double_col, date_string_col, string_col, timestamp_col, year, month FROM functional.alltypes db: default ... I20250910 07:36:52.956176 63842 jni-util.cc:321] 8a47939d765631e1:4821604e00000000] java.lang.IllegalStateException at com.google.common.base.Preconditions.checkState(Preconditions.java:496) at org.apache.impala.planner.HdfsScanNode.computeScanRangeLocations(HdfsScanNode.java:1364) at org.apache.impala.planner.HdfsScanNode.init(HdfsScanNode.java:444) at org.apache.impala.planner.SingleNodePlanner.createHdfsScanPlan(SingleNodePlanner.java:1684) at org.apache.impala.planner.SingleNodePlanner.createScanNode(SingleNodePlanner.java:1906) at org.apache.impala.planner.SingleNodePlanner.createTableRefNode(SingleNodePlanner.java:2235) at org.apache.impala.planner.SingleNodePlanner.createTableRefsPlan(SingleNodePlanner.java:937) at org.apache.impala.planner.SingleNodePlanner.createSelectPlan(SingleNodePlanner.java:752) at org.apache.impala.planner.SingleNodePlanner.createQueryPlan(SingleNodePlanner.java:284) at org.apache.impala.planner.SingleNodePlanner.createSingleNodePlan(SingleNodePlanner.java:176) at org.apache.impala.planner.Planner.createPlanFragments(Planner.java:137) at org.apache.impala.planner.Planner.createPlans(Planner.java:312) at org.apache.impala.service.Frontend.createExecRequest(Frontend.java:2031) at org.apache.impala.service.Frontend.getPlannedExecRequest(Frontend.java:3356) at org.apache.impala.service.Frontend.doCreateExecRequest(Frontend.java:3130) at org.apache.impala.service.Frontend.getTExecRequest(Frontend.java:2538) at org.apache.impala.service.Frontend.getTExecRequestWithFallback(Frontend.java:2407) at org.apache.impala.service.Frontend.createExecRequest(Frontend.java:2096) at org.apache.impala.service.JniFrontend.createExecRequest(JniFrontend.java:176) I20250910 07:36:52.956212 63842 status.cc:129] 8a47939d765631e1:4821604e00000000] IllegalStateException: null -- To view, visit http://gerrit.cloudera.org:8080/23363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c2a7119d76db7ce7c43caec2ccb122a014851b Gerrit-Change-Number: 23363 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sat, 13 Sep 2025 16:54:39 +0000 Gerrit-HasComments: Yes
