Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23219 )
Change subject: IMPALA-13437 (part 2): Implement cost-based tuple cache placement ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/23219/8/fe/src/main/java/org/apache/impala/planner/TupleCacheCostBasedPolicy.java File fe/src/main/java/org/apache/impala/planner/TupleCacheCostBasedPolicy.java: http://gerrit.cloudera.org:8080/#/c/23219/8/fe/src/main/java/org/apache/impala/planner/TupleCacheCostBasedPolicy.java@121 PS8, Line 121: Double.val > new Double() has been deprecated since Java 9, maybe use Double.valueOf() i Done http://gerrit.cloudera.org:8080/#/c/23219/8/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java File fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java: http://gerrit.cloudera.org:8080/#/c/23219/8/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java@260 PS8, Line 260: : public long getReadProcessingCost() { : checkFinalizedAndEligible("cost information"); > It seems we can create a private method for all these checks in multiple me Done http://gerrit.cloudera.org:8080/#/c/23219/8/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java@316 PS8, Line 316: costCoefficientWriteBytes > Do we wanna assert the thisPlanNode.getNumNodes() always larger than 0 here Done http://gerrit.cloudera.org:8080/#/c/23219/8/fe/src/main/java/org/apache/impala/planner/TupleCachePlanner.java File fe/src/main/java/org/apache/impala/planner/TupleCachePlanner.java: http://gerrit.cloudera.org:8080/#/c/23219/8/fe/src/main/java/org/apache/impala/planner/TupleCachePlanner.java@38 PS8, Line 38: * The cache placement algorithm is controlled by the 'tuple_cache_placement_policy' query : * option. See descriptions of these policies at {@ > We should update the comments for TupleCacheCostBasedPolicy and TupleCacheA Done -- To view, visit http://gerrit.cloudera.org:8080/23219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc6e7b95621a7937d892511dc879bf7c8da07cdc Gerrit-Change-Number: 23219 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 10 Sep 2025 21:49:21 +0000 Gerrit-HasComments: Yes
