Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23219 )
Change subject: IMPALA-13437 (part 2): Implement cost-based tuple cache placement ...................................................................... Patch Set 5: (3 comments) I'm doing a new upload on this primarily because I'm updating part 1. http://gerrit.cloudera.org:8080/#/c/23219/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23219/5//COMMIT_MSG@11 PS5, Line 11: locations within a budget. First, it eliminates unprofitable locations > This will need a docs update. Can you file a ticket for documentation aroun Filed IMPALA-14298 to document tuple caching http://gerrit.cloudera.org:8080/#/c/23219/5/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/23219/5/common/thrift/ImpalaService.thrift@1043 PS5, Line 1043: // cost_based: Pick locations that provide cost improvements while imposing a limit > nit: I'd swap the order of these to match their enum order. Done http://gerrit.cloudera.org:8080/#/c/23219/5/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_tuple_cache/tpcds-q01.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds_tuple_cache/tpcds-q01.test: http://gerrit.cloudera.org:8080/#/c/23219/5/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_tuple_cache/tpcds-q01.test@52 PS5, Line 52: | tuple-ids=5,2,4 row-size=74B cardinality=10.16M cost=0 > Should cost perhaps reflect "read processing cost"? I'm not sure how that w Tuple cache placement is now after cost-based planning, so the cost isn't used for anything after this point. It's awkward to display zero here, but it is also nice that the costs add up to the segment costs up at the plan fragment level. -- To view, visit http://gerrit.cloudera.org:8080/23219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc6e7b95621a7937d892511dc879bf7c8da07cdc Gerrit-Change-Number: 23219 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 12 Aug 2025 00:22:02 +0000 Gerrit-HasComments: Yes
