Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23380 )
Change subject: IMPALA-13806: Avoid per-function std::locale creation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23380/1/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23380/1/be/src/exprs/mask-functions-ir.cc@149 PS1, Line 149: & > >This could be a global (static) constant, which would save the initialisat Yes, it's not lazy but the memory needs to be allocated anyway, so we don't gain much by lazy initialisation. On the other hand, it probably doesn't make much of a difference either way so I'm fine with a local too. -- To view, visit http://gerrit.cloudera.org:8080/23380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a611ba1b175b0ab1c8f0d1de3b2439be70a68f7 Gerrit-Change-Number: 23380 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 05 Sep 2025 11:30:04 +0000 Gerrit-HasComments: Yes
