Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23380 )
Change subject: IMPALA-13806: Avoid per-function std::locale creation ...................................................................... Patch Set 1: (1 comment) Thanks for the patch! http://gerrit.cloudera.org:8080/#/c/23380/1/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23380/1/be/src/exprs/mask-functions-ir.cc@149 PS1, Line 149: & > Could you explain why we use reference (&) here? Is it still valid after th This could be a global (static) constant, which would save the initialisation check on each function call. Also, the lambda isn't really needed, it could be static const std::locale loc = boost::locale::generator{}("en_US.UTF-8"); -- To view, visit http://gerrit.cloudera.org:8080/23380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a611ba1b175b0ab1c8f0d1de3b2439be70a68f7 Gerrit-Change-Number: 23380 Gerrit-PatchSet: 1 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 04 Sep 2025 12:52:44 +0000 Gerrit-HasComments: Yes
