Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23382 )
Change subject: IMPALA-14400: Fix deadlock in CatalogServiceCatalog.getDbProperty() ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23382/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23382/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@503 PS2, Line 503: versionLock_.writeLock().lock(); I might forget something but why do we need write lock here? It seems we are not modifying anything in the block. http://gerrit.cloudera.org:8080/#/c/23382/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/23382/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@182 PS2, Line 182: catalog_.startEventsProcessor(); It doesn't make sense to start EventProcessor before the initial reset finish since we pause it and restart it in reset(). Will it also mitigate the issue if we don't start EventProcessor at the beginning? -- To view, visit http://gerrit.cloudera.org:8080/23382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3162472ea9531add77886bf1d0d73460ff34d07a Gerrit-Change-Number: 23382 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 04 Sep 2025 22:46:39 +0000 Gerrit-HasComments: Yes
