Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23382 )
Change subject: IMPALA-14400: Fix deadlock in CatalogServiceCatalog.getDbProperty() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23382/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23382/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@540 PS1, Line 540: waitInitialResetCompletion(dbName); I can use some feedback for this problem. Alternative fixes are: - Drop this waitInitialResetCompletion(). - Change all internal callsites to getDb() to obtain writeLock instead of readLock. Option 1 will cause slight inconsistency during startup / initial reset. Option 2 may reduce concurrency by obtaining stricter writeLock. Thus, I go with this getDbNoWait() approach. -- To view, visit http://gerrit.cloudera.org:8080/23382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3162472ea9531add77886bf1d0d73460ff34d07a Gerrit-Change-Number: 23382 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 04 Sep 2025 21:29:19 +0000 Gerrit-HasComments: Yes
