Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )
Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py File tests/metadata/test_load.py: http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py@207 PS1, Line 207: wait_start = exec_start > Agree that this can stabilize the test. But it's actually measuring the ent Here is my understanding on the timeline of the original test code in async mode: exec_start execute_query ExecuteInternal -> ClientRequestState::ExecLoadDataRequest() change state to PENDING Thread::Create for the worker thread return to Client exec_end get exec_end_state // the worker thread might not start yet (state is still PENDING) wait_start wait_for_impala_state to be FINISHED wait_end wait_time = wait_end - wait_start wait_time not strictly starts at the point when the thread starts. If it starts later due to get_impala_exec_state takes some time, wait_time < 3. So the original test code could fail at exec_end_state is PENDING or wait_time < 3. -- To view, visit http://gerrit.cloudera.org:8080/23360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37 Gerrit-Change-Number: 23360 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 02 Sep 2025 13:15:02 +0000 Gerrit-HasComments: Yes
