Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )
Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py File tests/metadata/test_load.py: http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py@207 PS1, Line 207: wait_start = exec_start Agree that this can stabilize the test. But it's actually measuring the entire duration of the statement. I think what we want the test to assert is that ExecuteStatement RPC returns quickly (for enable_async_load_data) regardless of the 3s delay. It's OK that after ExecuteStatement returns, the query state is PENDING or RUNNING. Clients like impala-shell will just wait for the FINISHED state. So I think that changing the assertions on L227-228 to below might be better: assert exec_end_state == PENDING or exec_end_state == RUNNING assert exec_time < 3 # or use a smaller value and keep the BE code unchanged so the debug action still mimic slowness in the DDL. -- To view, visit http://gerrit.cloudera.org:8080/23360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37 Gerrit-Change-Number: 23360 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 02 Sep 2025 13:06:45 +0000 Gerrit-HasComments: Yes
