Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23312 )
Change subject: IMPALA-14102: [part 1] Calcite Planner: optimize join rule ...................................................................... Patch Set 6: (3 comments) A couple of typos and line too long .. once these are addressed, it looks good to go. http://gerrit.cloudera.org:8080/#/c/23312/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23312/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-14102: [part 1] Calcite Planner: optimize join rule > Hoping new comment is better. Done http://gerrit.cloudera.org:8080/#/c/23312/4//COMMIT_MSG@13 PS4, Line 13: a placeh > Hoping new comment is better. Done http://gerrit.cloudera.org:8080/#/c/23312/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23312/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java@84 PS6, Line 84: fo typo: 'of' -- To view, visit http://gerrit.cloudera.org:8080/23312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63daf6dacf0547a0488c1ecf0bc185b548e00d87 Gerrit-Change-Number: 23312 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 02 Sep 2025 01:00:58 +0000 Gerrit-HasComments: Yes
