Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23312 )
Change subject: IMPALA-14102: [part 1] Calcite Planner: Pre-commit... ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/23312/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23312/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-14102: [part 1] Calcite Planner: Pre-commit... nit: instead of 'pre-commit' which doesn't convey a clear meaning, it would be better to say 'copy of LoptOptimizeJoinRule for subsequent modification' or something similar. http://gerrit.cloudera.org:8080/#/c/23312/4//COMMIT_MSG@13 PS4, Line 13: rule file nit: suggest mentioning the name of the rule. http://gerrit.cloudera.org:8080/#/c/23312/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23312/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java@76 PS4, Line 76: @Value.Enclosing In a separate javadoc comment, could you add a sentence that this is a copy of the same rule in Calcite version 1.37 and the rationale for making the copy. Why is it not a derived class where the amount of local changes could be minimized ? -- To view, visit http://gerrit.cloudera.org:8080/23312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63daf6dacf0547a0488c1ecf0bc185b548e00d87 Gerrit-Change-Number: 23312 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 27 Aug 2025 20:45:49 +0000 Gerrit-HasComments: Yes
