Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22914 )
Change subject: IMPALA-14081: Support create/drop paimon table for impala ...................................................................... Patch Set 15: (4 comments) Please also add some tests related to Paimon in AnalyzeDDLTest.java and ToSqlTest.java. http://gerrit.cloudera.org:8080/#/c/22914/14/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/22914/14/common/thrift/CatalogObjects.thrift@712 PS14, Line 712: // Paimon file system table location : 1: required binary tbl_obj > Very similar principal, it is a serialized object of underlying paimon api Ok. Thrift change can be difficult to do in the future (might require protocol version upgrade). Please make sure that this is OK, or easy to change in the future. http://gerrit.cloudera.org:8080/#/c/22914/15/fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java File fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java: http://gerrit.cloudera.org:8080/#/c/22914/15/fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java@42 PS15, Line 42: : public class PaimonAnalyzer { Add short documentation of what this new class is about. http://gerrit.cloudera.org:8080/#/c/22914/15/fe/src/main/java/org/apache/impala/catalog/paimon/FeShowFileStmtSupport.java File fe/src/main/java/org/apache/impala/catalog/paimon/FeShowFileStmtSupport.java: http://gerrit.cloudera.org:8080/#/c/22914/15/fe/src/main/java/org/apache/impala/catalog/paimon/FeShowFileStmtSupport.java@24 PS15, Line 24: : public interface FeShowFileStmtSupport { Add short documentation of what this new interface is about. http://gerrit.cloudera.org:8080/#/c/22914/15/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonTable.java File fe/src/main/java/org/apache/impala/catalog/paimon/PaimonTable.java: http://gerrit.cloudera.org:8080/#/c/22914/15/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonTable.java@54 PS15, Line 54: public class PaimonTable extends Table implements FePaimonTable { Add short documentation of what this new class is about. -- To view, visit http://gerrit.cloudera.org:8080/22914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e77f28151e4a91353ef77050f9f0cd7d9d05ef Gerrit-Change-Number: 22914 Gerrit-PatchSet: 15 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Fri, 29 Aug 2025 02:47:02 +0000 Gerrit-HasComments: Yes
