ji chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/22914 )
Change subject: IMPALA-14081: Support create/drop paimon table for impala ...................................................................... Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/22914/14/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/22914/14/common/thrift/CatalogObjects.thrift@712 PS14, Line 712: // Paimon file system table location : 1: required binary tbl_obj > Why this is binary? Very similar principal, it is a serialized object of underlying paimon api table, it is not possible to represented as collection of fields, since it is only an interface. metadata tables and two types of data tables: (primary key tables and append only tables) have their own internal implementation. so it will be very hard to represented as collection of fixed fields. http://gerrit.cloudera.org:8080/#/c/22914/14/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java File fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java: http://gerrit.cloudera.org:8080/#/c/22914/14/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java@415 PS14, Line 415: return Optional.empty(); > Please Log WARNING if this happen. Done http://gerrit.cloudera.org:8080/#/c/22914/14/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: http://gerrit.cloudera.org:8080/#/c/22914/14/tests/metadata/test_show_create_table.py@91 PS14, Line 91: def test_show_create_table_paimon(self, vector, unique_database): > Please mark this test class with @SkipIf.not_hdfs until we can validate tha Done http://gerrit.cloudera.org:8080/#/c/22914/14/tests/query_test/test_paimon.py File tests/query_test/test_paimon.py: http://gerrit.cloudera.org:8080/#/c/22914/14/tests/query_test/test_paimon.py@24 PS14, Line 24: : class TestCreatingPaimonTable(ImpalaTestSuite): > Please mark this test class with @SkipIf.not_hdfs until we can validate tha Done -- To view, visit http://gerrit.cloudera.org:8080/22914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e77f28151e4a91353ef77050f9f0cd7d9d05ef Gerrit-Change-Number: 22914 Gerrit-PatchSet: 14 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Wed, 27 Aug 2025 00:33:02 +0000 Gerrit-HasComments: Yes
