Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23279 )
Change subject: IMPALA-13237: [Patch 8] - OpenTelemetry Traces for DML/DDL Queries and Handle Leading Comments ...................................................................... Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/23279/19/be/src/observe/otel.cc File be/src/observe/otel.cc: http://gerrit.cloudera.org:8080/#/c/23279/19/be/src/observe/otel.cc@109 PS19, Line 109: : // Lambda function to check if SQL starts with relevant keywords for tracing : static const function<bool(std::string_view)> is_traceable_sql = > Have you thought about replacing new lines with space instead (after droppi I wish I could. That would require copying the sql string though which I want to avoid. http://gerrit.cloudera.org:8080/#/c/23279/19/be/src/observe/otel.cc@161 PS19, Line 161: continue; : } : } else if (boost::algorithm::istarts_ > How this is handled? The query tracing is skipped. Opened IMPALA-14370 to fix this in a later change. Interestingly enough, a query such as this will get traced because the query_newline regex catches it: /*/ comment */select * from tbl -- To view, visit http://gerrit.cloudera.org:8080/23279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e83d7f761f3d629f067e0a0602224e42cd7184 Gerrit-Change-Number: 23279 Gerrit-PatchSet: 20 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 28 Aug 2025 21:22:34 +0000 Gerrit-HasComments: Yes
