Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23279 )
Change subject: IMPALA-13237: [Patch 8] - OpenTelemetry Traces for DML/DDL Queries and Handle Leading Comments ...................................................................... Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/23279/19/be/src/observe/otel.cc File be/src/observe/otel.cc: http://gerrit.cloudera.org:8080/#/c/23279/19/be/src/observe/otel.cc@109 PS19, Line 109: static const regex query_newline( : "(select|alter|compute|create|delete|drop|insert|invalidate|update|with)\\s*" : "(\n|\\s*\\\\*\\/)", regex::icase | regex::optimize | regex::nosubs); Have you thought about replacing new lines with space instead (after dropping leading comment lines)? Thus, the input sql will always be in single line. http://gerrit.cloudera.org:8080/#/c/23279/19/be/src/observe/otel.cc@161 PS19, Line 161: if (boost::algorithm::istarts_with(sql, "/*")) { : // Handle leading inline comments : size_t end_comment = sql.find("*/") How this is handled? /*/ this is comment */ SELECT 1; -- To view, visit http://gerrit.cloudera.org:8080/23279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e83d7f761f3d629f067e0a0602224e42cd7184 Gerrit-Change-Number: 23279 Gerrit-PatchSet: 19 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 28 Aug 2025 20:59:07 +0000 Gerrit-HasComments: Yes
