Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23012 )
Change subject: IMPALA-9874: Skip IO for late materialized columns ...................................................................... Patch Set 13: Code-Review+1 (1 comment) lgtm, one more test idea http://gerrit.cloudera.org:8080/#/c/23012/13/tests/query_test/test_parquet_late_materialization.py File tests/query_test/test_parquet_late_materialization.py: http://gerrit.cloudera.org:8080/#/c/23012/13/tests/query_test/test_parquet_late_materialization.py@119 PS13, Line 119: def test_skip_collection_column(self, unique_database): one more test idea: can you check if skipping works if there are multiple row groups in the file? functional_parquet.lineitem_multiblock should be usable for this -- To view, visit http://gerrit.cloudera.org:8080/23012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a052b028220517503e634e3f916d1fbd60eb65d Gerrit-Change-Number: 23012 Gerrit-PatchSet: 13 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 28 Aug 2025 12:21:02 +0000 Gerrit-HasComments: Yes
